Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign an Id to windows #131

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Assign an Id to windows #131

merged 1 commit into from
Nov 1, 2023

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Nov 1, 2023

This assigns an Id to windows so that set_current_view can be used when creating the view for the window. This allows messages send during the view creation to be correctly delivered.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #131 (75fbb5f) into main (6f39d64) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #131      +/-   ##
========================================
- Coverage   3.18%   3.16%   -0.03%     
========================================
  Files         54      54              
  Lines       9764    9832      +68     
========================================
  Hits         311     311              
- Misses      9453    9521      +68     
Files Coverage Δ
src/views/text_input.rs 8.20% <0.00%> (ø)
src/id.rs 0.00% <0.00%> (ø)
src/context.rs 0.00% <0.00%> (ø)
src/window_handle.rs 0.00% <0.00%> (ø)
src/style.rs 15.90% <0.00%> (-1.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dzhou121 dzhou121 merged commit 920ca6b into lapce:main Nov 1, 2023
9 checks passed
@Zoxc Zoxc deleted the window-ids branch November 1, 2023 09:57
jrmoulton pushed a commit to jrmoulton/floem that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants