-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Winit window configuration, change default rendering colour #124
Conversation
f1b2fcc
to
2b1a2d9
Compare
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
========================================
- Coverage 3.21% 3.19% -0.03%
========================================
Files 54 54
Lines 9581 9642 +61
========================================
Hits 308 308
- Misses 9273 9334 +61
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -442,7 +442,12 @@ impl Renderer for VgerRenderer { | |||
view: &texture_view, | |||
resolve_target: None, | |||
ops: wgpu::Operations { | |||
load: wgpu::LoadOp::Clear(wgpu::Color::WHITE), | |||
load: wgpu::LoadOp::Clear(wgpu::Color { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe only do this if the window is transparent? also why a is 0.5 instead of 0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there such configuration? The transparency setting is for winit to signal to OS that it might be transparent.
also why a is 0.5 instead of 0.0?
my own custom thing, will fix in a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's what I meant, when the WindowConfig has transparent setting in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how I'm supposed to do that, winit doesn't even expose the transparency state in Window, only in WindowBuilder
…apce#124) * extend winit window creation, re-export winit, make wgpu render transparent * format code * fix transparency to 0.0
…parent