Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unwrap crash when render surface is unavailable (0 height etc) #117

Merged
merged 1 commit into from
Oct 8, 2023
Merged

fix unwrap crash when render surface is unavailable (0 height etc) #117

merged 1 commit into from
Oct 8, 2023

Conversation

Keshi
Copy link
Contributor

@Keshi Keshi commented Oct 8, 2023

Repro

  1. Run examples/responsive (or probably any example?)
  2. Vertically resize the window to the smallest possible so that only menu bars are showing (0 height surface)

Observed

  • Crash
  • surface.get_current_texture() returns Err

This PR makes the UI just temporarily not render, instead of crashing the application.

@dzhou121
Copy link
Contributor

dzhou121 commented Oct 8, 2023

Thanks!

@dzhou121 dzhou121 merged commit 2ef077e into lapce:main Oct 8, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keshi @dzhou121