fix new clippy in workspace

lapce · Dec 6, 2024 · 439548d · 439548d
1 parent e96c39f
commit 439548d
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/editor-core/src/char_buffer.rs b/editor-core/src/char_buffer.rs
@@ -81,7 +81,7 @@ impl CharBuffer {
     #[inline]
     pub fn new(char: char) -> Self {
         let mut buf = [0; 4];
-        let len = char.encode_utf8(&mut buf).as_bytes().len();
+        let len = char.encode_utf8(&mut buf).len();
         Self { len, buf }
     }
 

diff --git a/examples/syntax-editor/src/main.rs b/examples/syntax-editor/src/main.rs
@@ -41,7 +41,7 @@ struct SyntaxHighlightingStyle<'a> {
     pub states: RefCell<Vec<(ParseState, HighlightState)>>,
 }
 
-impl<'a> SyntaxHighlightingStyle<'a> {
+impl SyntaxHighlightingStyle<'_> {
     pub fn new(style: Rc<dyn Styling>) -> Self {
         let theme = &THEMES.themes["base16-ocean.dark"];
         let rust = SYNTAXSET.find_syntax_by_extension("rs").unwrap();
@@ -61,7 +61,7 @@ impl<'a> SyntaxHighlightingStyle<'a> {
     }
 }
 
-impl<'a> Styling for SyntaxHighlightingStyle<'a> {
+impl Styling for SyntaxHighlightingStyle<'_> {
     fn id(&self) -> u64 {
         self.style.id()
     }

diff --git a/examples/todo-complex/src/main.rs b/examples/todo-complex/src/main.rs
@@ -151,7 +151,7 @@ enum AppCommand<'a> {
     SelectUp,
     SelectDown,
 }
-impl<'a> AppCommand<'a> {
+impl AppCommand<'_> {
     fn execute(self) {
         let (active, selected, todos) = TODOS_STATE.with(|s| (s.active, s.selected, s.todos));
         TODOS_STATE.with(|s| {

diff --git a/examples/todo-complex/src/todo.rs b/examples/todo-complex/src/todo.rs
@@ -76,8 +76,7 @@ impl IntoView for TodoState {
         });
 
         let (active, selected) = TODOS_STATE.with(|s| (s.active, s.selected));
-        let is_active =
-            create_memo(move |_| active.with(|a| a.active.map_or(false, |v| v == self)));
+        let is_active = create_memo(move |_| active.with(|a| (a.active == Some(self))));
         let is_selected = create_memo(move |_| selected.with(|s| s.contains(&self)));
 
         let todo_action_menu = move || {

diff --git a/src/views/text_input.rs b/src/views/text_input.rs
@@ -677,7 +677,7 @@ impl TextInput {
                 .key
                 .text
                 .as_ref()
-                .map_or(false, |ch| self.insert_text(ch)),
+                .is_some_and(|ch| self.insert_text(ch)),
             Key::Named(NamedKey::Space) => {
                 if let Some(selection) = &self.selection {
                     self.buffer