Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slurmrestd version function #953

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Fix slurmrestd version function #953

wants to merge 9 commits into from

Conversation

rstyd
Copy link
Collaborator

@rstyd rstyd commented Nov 4, 2024

This PR fixes the slurmrestd inference function. It also adds a debug message that states what version it finds.

pagrubel
pagrubel reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rstyd Should there be a fix for the configuration file?

@pagrubel pagrubel added the WIP Work in progress label Nov 12, 2024
@pagrubel
Copy link
Collaborator

Please remove api version from config and use whatever is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pagrubel pagrubel pagrubel left review comments

@kchilleri kchilleri Awaiting requested review from kchilleri

At least 1 approving review is required to merge this pull request.

Assignees

@kchilleri kchilleri

Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rstyd @pagrubel @kchilleri