Initial task manager resiliency and error handling #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Task Manager will now resubmit jobs that failed due to error statuses indicating failures not caused by the job itself, such as NODE_FAIL. These are all Slurm state codes right now and may not be applicable to other schedulers like Flux.
Adds a ContainerBuildError exception to be thrown on builder failures. The Task Manager catches this and sets task states to BUILD_FAIL.
aquan9
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some initial changes to improve resiliency and error-handling in the task manager. This doesn't completely resolve issues #675 and #676, but I thought I'd open this now since these changes are relatively self-contained. Rusty and I discussed those issues and we were thinking it might be best to have a longer discussion about them and the interaction between the task manager and the workflow manager.
Also, I think this should resolve #550. The builder should now be throwing exceptions when it fails to build or pull a container. I added an integration test case for an invalid container build.