Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store submit command args in designated workflow directory. #778

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Store submit command args in designated workflow directory. #778

merged 8 commits into from
Feb 15, 2024

Conversation

kchilleri
Copy link
Collaborator

Addresses issue #742.

@kchilleri kchilleri requested a review from pagrubel February 8, 2024 21:08
@kchilleri kchilleri linked an issue Feb 8, 2024 that may be closed by this pull request
Archive should contain submit command #742
Closed
pagrubel
pagrubel reviewed Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@pagrubel pagrubel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider using fstrings
f.write(f"wf_name: {wf_name}\n")

@kchilleri kchilleri requested a review from pagrubel February 15, 2024 21:40
pagrubel
pagrubel approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kchilleri you are now officially a contributor to the BEE project.

@pagrubel pagrubel merged commit d76b04f into develop Feb 15, 2024
4 checks passed
@pagrubel pagrubel deleted the issue742/archive-should-contain-submit-command branch February 15, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pagrubel pagrubel pagrubel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archive should contain submit command
2 participants
@kchilleri @pagrubel