Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue700/remove archive workflows #774

Merged
merged 13 commits into from
Feb 21, 2024
Merged

Conversation

pagrubel
Copy link
Collaborator

@pagrubel pagrubel commented Feb 2, 2024

Add beeflow remove command to remove Archived or Cancelled workflows.

  • add beeflow remove
  • add unit test for beeflow remove
  • ignore *.tar and *.log files in repo
  • add method to get workflow status
  • add 'cancelandremove` to the delete wf_action

This PR addresses #700

@pagrubel pagrubel requested review from jtronge and aquan9 February 5, 2024 17:19
@pagrubel pagrubel requested a review from kchilleri February 7, 2024 18:03
@kchilleri
Copy link
Collaborator

This remove command works for me. However, I have two things to note:

  1. An archived workflow is successfully removed from /.beeflow/workflows but its wf_id.tgz remains in /.beeflow/archives. Should this file be permanently removed as well?
  2. After successfully removing an archived workflow and running a beeflow query already_removed_wf_id outputs an error with the WFM and produces an error log. Should we print a "workflow with already_removed_wf_id does not exist" error instead?

@pagrubel
Copy link
Collaborator Author

@kchilleri I'll check out your comments and see if changes should be done! Thanks for looking at it.

@pagrubel
Copy link
Collaborator Author

@kchilleri I could not duplicate the error you got. This is what I did:

Name	ID	Status
clamr-example	e81af8	Archived
clamr-example	efbca7	Archived
(hpc-beeflow-py3.11) pagrubel@darwin-fe2 BEE$ beeflow remove ef
Workflow Status is Archived
All stored information for workflow efbca7 will be removed.
Continue to remove? yes(y)/no(n): y
Workflow removed!
(hpc-beeflow-py3.11) pagrubel@darwin-fe2 BEE$ beeflow query ef
Match_short_id: Provided workflow ID does not match any submitted workflows
(hpc-beeflow-py3.11) pagrubel@darwin-fe2 BEE$ 

Could you paste what you get?

@kchilleri
Copy link
Collaborator

@pagrubel This is what I got the first time I tried it.

(hpc-beeflow-py3.9) (base) [kchilleri@darwin-fe3 BEE]$ beeflow list
Name	ID	Status
example1	e8d046	Archived
(hpc-beeflow-py3.9) (base) [kchilleri@darwin-fe3 BEE]$ beeflow remove e8d046
Workflow Status is Archived
All stored information for workflow e8d046 will be removed.
Continue to remove? yes(y)/no(n): y
Workflow removed!
(hpc-beeflow-py3.9) (base) [kchilleri@darwin-fe3 BEE]$ beeflow list
There are currently no workflows.
(hpc-beeflow-py3.9) (base) [kchilleri@darwin-fe3 BEE]$ beeflow query e8d046
There are currently no workflows.
An error occurred with the WFM. Please save your workflow and the
error log "bee-error-1708463635.log". If possible, please report this
to the BEE development team.

I'll try again!

@pagrubel
Copy link
Collaborator Author

@kchilleri Okay I get the error now when there are no more workflows.

@pagrubel
Copy link
Collaborator Author

@kchilleri Great catch that error occurred for any of several methods in bee_client. Both issues should be fixed now.

Copy link
Collaborator

@kchilleri kchilleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me.

@pagrubel pagrubel merged commit 2ea76d9 into develop Feb 21, 2024
8 checks passed
@pagrubel pagrubel deleted the issue700/remove_archive_workflows branch February 21, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants