Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug when adding openai or openai-compatible stt model instance #9006

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix bug when adding openai or openai-compatible stt model instance #9006

merged 3 commits into from
Oct 7, 2024

Conversation

zhao85
Copy link
Contributor

@zhao85 zhao85 commented Oct 3, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes #8811
Fixes #9018
Fixes #9032

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • the adding of speech2text to openai/openai-api-compatible is now ok

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 3, 2024
@crazywoola crazywoola requested a review from laipz8200 October 5, 2024 14:08
laipz8200
laipz8200 previously approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2024
@zhao85
fix a BUG of Final Answer failure
2e04e4b 
* ReAct LLM often response Final Answer with newline \n, which would cause the json.loads failed.
@zhao85
Copy link
Contributor Author

zhao85 commented Oct 6, 2024

Found a bug in ReAct Final Answer parsing. @laipz8200 @crazywoola

@crazywoola crazywoola merged commit fcfa125 into langgenius:main Oct 7, 2024
6 checks passed
cuiks pushed a commit to cuiks/dify that referenced this pull request Oct 8, 2024
@zhao85 @cuiks
fix bug when adding openai or openai-compatible stt model instance (l…
55aa216 
…anggenius#9006)
@laipz8200 laipz8200 mentioned this pull request Oct 14, 2024
Merged
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@zhao85 @lau-td
fix bug when adding openai or openai-compatible stt model instance (l…
052af6c 
…anggenius#9006)
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@zhao85 @JunXu01
fix bug when adding openai or openai-compatible stt model instance (l…
bc7eda5 
…anggenius#9006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

@laipz8200 laipz8200 laipz8200 left review comments

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@zhao85 @laipz8200 @crazywoola