Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: api/core/ops/ops_trace_manager.py #8501

Merged
merged 3 commits into from
Sep 21, 2024
Merged

fix: api/core/ops/ops_trace_manager.py #8501

merged 3 commits into from
Sep 21, 2024

Conversation

ZuzooVn
Copy link
Contributor

@ZuzooVn ZuzooVn commented Sep 17, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes

get_ops_trace_instance
provider_config_map[tracing_provider]['trace_instance'], 
KeyError: None

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Sep 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 21, 2024
@ZhouhaoJiang ZhouhaoJiang merged commit 8219f9e into langgenius:main Sep 21, 2024
6 checks passed
@ZuzooVn ZuzooVn deleted the fix--ops_trace_manager.py branch September 21, 2024 14:04
hgnulb pushed a commit to hgnulb/dify that referenced this pull request Sep 26, 2024
@ZuzooVn
fix: api/core/ops/ops_trace_manager.py (langgenius#8501)
2b2d01a
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
@ZuzooVn @cuiks
fix: api/core/ops/ops_trace_manager.py (langgenius#8501)
a74382a
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@ZuzooVn @lau-td
fix: api/core/ops/ops_trace_manager.py (langgenius#8501)
2fcf9e0
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@ZuzooVn @JunXu01
fix: api/core/ops/ops_trace_manager.py (langgenius#8501)
8a8f733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhouhaoJiang ZhouhaoJiang ZhouhaoJiang approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZuzooVn @ZhouhaoJiang