Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert page column #8217

Merged
merged 1 commit into from
Sep 10, 2024
Merged

revert page column #8217

merged 1 commit into from
Sep 10, 2024

Conversation

JohnJyong
Copy link
Contributor

@JohnJyong JohnJyong commented Sep 10, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

revert page column

Fixes #8211
Fixes #8175
Fixes #8117

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 10, 2024
@crazywoola
Copy link
Member

crazywoola commented Sep 10, 2024

@ifsheldon @jasonkang14 FYI

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@JohnJyong JohnJyong merged commit bb3002b into main Sep 10, 2024
9 checks passed
@JohnJyong JohnJyong deleted the fix/remove-weavite-page-column branch September 10, 2024 10:21
@crazywoola crazywoola mentioned this pull request Sep 13, 2024
5 tasks
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
2 participants