Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor the beichuan model #7953

Merged
merged 8 commits into from
Sep 4, 2024
Merged

chore: refactor the beichuan model #7953

merged 8 commits into from
Sep 4, 2024

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Sep 4, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

currently, there is a lot of changes of beichuan API, this refactor include changes:

  • remove deprecated models: baichuan2-turbo-192k, baichuan2-53b
  • remove deprecated params: presence_penalty, frequency_penalty
  • compatible the with_search_enhance
  • support json_object
  • support multi-tool-call
  • support system role
  • other code readablity optimizations

offical doc: https://platform.baichuan-ai.com/docs/api#12

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

local test in agent and workflow apps

1725421606620

  • Test A
  • Test B

@hjlarry hjlarry marked this pull request as ready for review September 4, 2024 04:08
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. ⚙️ feat:model-runtime labels Sep 4, 2024
@hjlarry
Copy link
Contributor Author

hjlarry commented Sep 4, 2024

the CI error seems not related to this PR, and not stable, why previous Run Pytest / API Tests (3.10) (pull_request) is passed

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
@crazywoola crazywoola merged commit 0f72a8e into langgenius:main Sep 4, 2024
6 checks passed
ProseGuys pushed a commit to hustyichi/dify that referenced this pull request Sep 5, 2024
mehrajagdish pushed a commit to Sbazar-GmbH/dify that referenced this pull request Sep 6, 2024
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants