fix(api): Code-Based Extension cause error on position map sorting #7934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3981 TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: 陳鈞 <[email protected]>
dosubot
bot
added
size:XS
|
Thank you very much for your discovery. :) |
crazywoola
approved these changes
Sep 4, 2024
ZhouhaoJiang
added a commit
that referenced
this pull request
Sep 4, 2024
* refs/heads/main: (219 commits) Revert "fix: an issue of keyword search feature in application log list" (#7949) chore: #7943 i18n (#7948) fix(api): Code-Based Extension cause error on position map sorting (#7934) Chore/add roadmap (#7943) Chore/add default step 1x url (#7933) fix rerank model value is empty string (#7937) chore: #7603 i18n (#7931) Fix/segment create with api (#7928) improve the notion table extract (#7925) fix: frontend handle sometimes server not generate the wrong follow up data struct (#7916) feat: support auto generate i18n translate (#6964) chore: Update versions to 0.7.3 (#7895) chore(Dockerfile): Bump expat to 2.6.2-2 (#7904) fix: correct typo in the setting screen (#7897) feat: allow users to use the app icon as the answer icon (#7888) ignore linked images when image id is none (#7890) Add Russian language (#7860) fix: fixed typo on loading reranking_mode (#7887) Add perplexity search as a new tool (#7861) fix: glm models prices and max_tokens correction (#7882) ... # Conflicts: # api/core/workflow/nodes/question_classifier/question_classifier_node.py
mehrajagdish
pushed a commit
to Sbazar-GmbH/dify
that referenced
this pull request
Sep 6, 2024
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Sep 26, 2024
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3981 and should continue to track the remain issue at #6528.
Note: The Code-Based Extension still does not appear on the interface.
I am submitting this PR mainly to explain my findings in the error, in order to save time for the next developer fixing the Code-Based Extension.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
The issue is because there is None in the
position_map.This piece of code assigns None to
positionand stores it inposition_map[extension_name]when not entering the if statement.https://github.com/langgenius/dify/blob/main/api/core/extension/extensible.py#L60-L68
This implementation ensures that when no value is get from the
position_map, it uses infinity as the default value.But there's None inside the
position_map.Then it was taken out for comparison, and the error occurred.
https://github.com/langgenius/dify/blob/main/api/core/helper/position_helper.py#L120
Type of Change
Testing Instructions
This error occurs at startup and causes the program to exit immediately when you have Code-Based Extension in the external_data_tool folder.
After the correction, the error message disappeared and the api started normally.
(But the Code-Based Extension still doesn't show up at frontend.)