Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script and functions for checking Celery worker liveness and ready. #7870

Closed

Conversation

Seayon
Copy link
Contributor

@Seayon Seayon commented Sep 1, 2024

…iness

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Close: #7869

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I deploy it to the k8s, using command health check
sh -c python extensions/ext_scripts/ext_celery_worker_liveness.py

and it works well.

  • Test B

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Sep 1, 2024
@laipz8200
Copy link
Member

Hi, thank you for contributing such beautiful code. It looks like this is an informal probe implementation. Could you modify it only on your deployed version?

@Seayon
Copy link
Contributor Author

Seayon commented Sep 1, 2024

Hi, thank you for contributing such beautiful code. It looks like this is an informal probe implementation. Could you modify it only on your deployed version?

OK, I understand and will use this in my own deployment. I hope the Celery community can provide an good official implementation soon

@Seayon Seayon closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Lightweight Health Check for Celery Worker in Kubernetes
2 participants