Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/s3 iam add region name #7819

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Fix/s3 iam add region name #7819

merged 2 commits into from
Oct 12, 2024

Conversation

GarfieldDai
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@GarfieldDai GarfieldDai force-pushed the fix/s3-iam-add-region-name branch from ae251bc to 6f858ce Compare October 12, 2024 08:14
fix: s3 iam add region name.

fix: s3 iam add region name.

fix: s3 iam add region name.
@GarfieldDai GarfieldDai force-pushed the fix/s3-iam-add-region-name branch 2 times, most recently from 71fe617 to 5b5e061 Compare October 12, 2024 10:27
@GarfieldDai GarfieldDai marked this pull request as ready for review October 12, 2024 10:32
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 12, 2024
@chocoboxu chocoboxu removed their request for review October 12, 2024 10:44
@GarfieldDai GarfieldDai requested a review from chocoboxu October 12, 2024 10:44
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 12, 2024
@GarfieldDai GarfieldDai merged commit c6b74da into main Oct 12, 2024
9 checks passed
@GarfieldDai GarfieldDai deleted the fix/s3-iam-add-region-name branch October 12, 2024 10:48
ZhouhaoJiang added a commit that referenced this pull request Oct 14, 2024
* main: (121 commits)
  fix: remove the latest message from the user that does not have any answer yet (#9297)
  Add Volcengine VikingDB as new vector provider (#9287)
  chore: translate i18n files (#9288)
  chore: add baidu-obs and supabase for .env.example (#9289)
  chore: add abstract decorator and output log when query embedding fails (#9264)
  Feat/new account page (#9236)
  Feat/implement-refresh-tokens (#9233)
  feat: refresh-token (#9286)
  chore: translate i18n files (#9284)
  feat:support baidu vector db (#9185)
  Feat: rerank model verification in front end (#9271)
  Fix/s3 iam add region name (#7819)
  chore: optimize the trace ops slow queries on node executions. (#9282)
  chore: use cache instead of re-querying node record during workflow execution (#9280)
  chore: fix the misclassification of the opensearch-py package (#9266)
  fix: add new domain to whitelist (#9265)
  fix: move exception to debug mode (#9258)
  feat: add supabase object storage (#9229)
  fix: dialog box cannot correctly display LaTeX formulas (#9242)
  Fix/agent external knowledge retrieval (#9241)
  ...
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Oct 21, 2024
* commit '5c7b1358d49c8df54bc39eea7b9c4d9b41c09fcb': (235 commits)
  chore(release): bump version to 0.9.2 (langgenius#9314)
  fix: token refreshing logic issue (langgenius#9308)
  fix: Add new Milvus Lite wheel for manylinux2014_aarch64 (langgenius#9316)
  chore: add reopen preview btn (langgenius#9279)
  chore: Optimize operations in Q&A mode (langgenius#9274)
  refactor: Refactor the service of retrieval the recommend app (langgenius#9302)
  chore: remove the copied zhipu_ai sdk (langgenius#9270)
  fix: remove the latest message from the user that does not have any answer yet (langgenius#9297)
  Add Volcengine VikingDB as new vector provider (langgenius#9287)
  chore: translate i18n files (langgenius#9288)
  chore: add baidu-obs and supabase for .env.example (langgenius#9289)
  chore: add abstract decorator and output log when query embedding fails (langgenius#9264)
  Feat/new account page (langgenius#9236)
  Feat/implement-refresh-tokens (langgenius#9233)
  feat: refresh-token (langgenius#9286)
  chore: translate i18n files (langgenius#9284)
  feat:support baidu vector db (langgenius#9185)
  Feat: rerank model verification in front end (langgenius#9271)
  Fix/s3 iam add region name (langgenius#7819)
  chore: optimize the trace ops slow queries on node executions. (langgenius#9282)
  ...

# Conflicts:
#	web/package.json
#	web/yarn.lock
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants