Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add:save_model_credentials error log #7630

Merged

Conversation

pinsily
Copy link
Contributor

@pinsily pinsily commented Aug 26, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This PR enhances the error logging for the save_model_credentials method in the ModelProviderModelApi class. By adding a detailed stack trace log when a CredentialsValidateFailedError occurs, we improve our ability to debug and quickly identify the root cause of credential validation failures, especially in complex model validation scenarios.

This change does not alter the existing functionality but significantly improves observability, which is crucial for troubleshooting in production environments.

Fixes #[Issue number] (Please replace with the actual issue number if one exists)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

To verify this change:

  • Intentionally trigger a CredentialsValidateFailedError in the save_model_credentials method
  • Check the logs to ensure the full stack trace is present
  • Run existing unit tests to confirm no regression

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 💪 enhancement New feature or request labels Aug 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 26, 2024
@crazywoola crazywoola merged commit a7743a4 into langgenius:main Aug 26, 2024
6 checks passed
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants