Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up the Docker build for dify-api for Chinese developers. #7626

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

erigo
Copy link
Contributor

@erigo erigo commented Aug 26, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fix #7622

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 💪 enhancement New feature or request labels Aug 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 26, 2024
@crazywoola crazywoola merged commit 103ff28 into langgenius:main Aug 26, 2024
6 checks passed
@erigo erigo deleted the feat/speed-up-docker-build branch August 26, 2024 07:40
@bowenliang123
Copy link
Contributor

bowenliang123 commented Nov 11, 2024

I suggest reverting this PR, for the reasons:

  • it brings no feature or fix to the Dify users
  • all the changes should be considered for the global Dify users across the world, not just for Chinese users'
  • it implies a private vendor of Python Pypi's mirrors
  • changing the mirror is easy and simple
  • plenty of mirrors could be added for pip, yarn, node and many other Dify used package managers.

cc @crazywoola @laipz8200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to speed up the Docker build for dify-api for Chinese developers.
3 participants