Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite Elasticsearch index and search code to achieve Elasticsearch vector and full-text search #7472

Closed
wants to merge 13 commits into from

Conversation

KennFalcon
Copy link
Contributor

@KennFalcon KennFalcon commented Aug 21, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Aug 21, 2024
@crazywoola crazywoola requested a review from JohnJyong August 21, 2024 05:26
@crazywoola
Copy link
Member

Please fix the errors in CI

@KennFalcon
Copy link
Contributor Author

KennFalcon commented Aug 22, 2024

I think there is a problem with the ES volume mount in the docker-compose.yml file, which is causing the ES containers in the workflow process to go down. So I changed the mounting method of the ES data directory look like opensearch.

@KennFalcon
Copy link
Contributor Author

Can retry the workflow? I can't reproduce the test issue on my own ES service. @crazywoola

JohnJyong
JohnJyong previously approved these changes Aug 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2024
@KennFalcon
Copy link
Contributor Author

Still has error, I will try to fix it.

@bowenliang123
Copy link
Contributor

👍🏻 Glad to have this refactoring.

@KennFalcon KennFalcon closed this Aug 26, 2024
@KennFalcon
Copy link
Contributor Author

Need rollback some commit. So close the pr, and create new. #7641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants