-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract db configs and celery configs into dify config #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenliang123
changed the title
extract db configs
refactor: extract db configs and celery configs into dify config
Jun 21, 2024
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Jun 21, 2024
takatost
requested changes
Jun 22, 2024
bowenliang123
force-pushed
the
db-configs
branch
from
June 22, 2024 02:03
b7c5766
to
32226d0
Compare
takatost
requested changes
Jun 22, 2024
bowenliang123
force-pushed
the
db-configs
branch
from
June 22, 2024 02:12
6f40a07
to
171e408
Compare
takatost
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XiaoLey
pushed a commit
to XiaoLey/dify
that referenced
this pull request
Jun 22, 2024
ZhouhaoJiang
added a commit
that referenced
this pull request
Jun 24, 2024
* refs/heads/deploy/dev: (273 commits) chore: host required fix: monitor copywrite feat: make show citations enable default chore: use singular style in middleware config class name (#5502) refactor: extract hosted service configs into dify config (#5504) fix: summary of duckduckgo_search (#5488) fix: zhipu tool calling, this PR fixes the bug described in issue #5496 (#5469) fix: tongyi json output (#5396) fix: firecrawl apikey not start with fc- (#5498) fix lock refactor: extract db configs and celery configs into dify config (#5491) refactor: extract storage provider configs into dify configs (#5443) chore: use singular style in config class name (#5489) chore: remove pip support for api service (#5453) Add Oracle23ai as a vector datasource (#5342) build: support Poetry for depencencies tool in api's Dockerfile (#5105) feat: add ops trace encrypt_config decrypt_config obfuscate_config feat: add remove tracing app fix: max_tokens of qwen-plus & qwen-plus-chat (#5480) feat: add support for Vertex AI claude-3-5-sonnet@20240620 (#5475) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes