Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1.0): add missing environment variable #12599

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Jan 10, 2025

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

the missing environment variable raise various errors, and can't pass CI

(.venv) ~\PycharmProjects\dify git:[28edbbac0]
poetry run -C api python dev/pytest/pytest_config_tests.py
API and Docker config sets are different with key: {'PLUGIN_API_KEY', 'INNER_API_KEY', 'PLUGIN_REMOTE_INSTALL_HOST', 'PLUGIN_REMOTE_INSTALL_PORT', 'INNER_API_KEY_FOR_PLUGIN', 'PLUGIN_API_URL'}
Traceback (most recent call last):
  File "C:\Users\hejl\PycharmProjects\dify\dev\pytest\pytest_config_tests.py", line 111, in <module>
    test_yaml_config()
  File "C:\Users\hejl\PycharmProjects\dify\dev\pytest\pytest_config_tests.py", line 96, in test_yaml_config
    raise Exception("API and Docker config sets are different")
Exception: API and Docker config sets are different

I think there are also some duplicate keys, but make it consistency first.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 10, 2025
docker/.env.example Outdated Show resolved Hide resolved
docker/.env.example Outdated Show resolved Hide resolved
docker/docker-compose.yaml Outdated Show resolved Hide resolved
@hjlarry hjlarry requested a review from Yeuoly January 10, 2025 08:22
@Yeuoly
Copy link
Collaborator

Yeuoly commented Jan 10, 2025

Please also change them in docker-compose-template.yaml thanks !

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 10, 2025
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 10, 2025
@Yeuoly Yeuoly merged commit ac336ff into langgenius:plugins/beta Jan 10, 2025
2 of 5 checks passed
@Yeuoly
Copy link
Collaborator

Yeuoly commented Jan 10, 2025

remaining fixes will be done in #12615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants