-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo in clean messages periodical task's logging #12090
fix: typo in clean messages periodical task's logging #12090
Conversation
61f47c1
to
a76aef7
Compare
Hi @JohnJyong, may I ask for your advice to improve this PR? And what's the main reason for closing this PR? |
Hi @bowenliang123. Sorry for close this PR directly, because this task is related to Cloud services. At the moment, we believe it does not require any changes. |
Thanks for keeping me informed. Or may I strip changes and only fix the typo in logging, if you can reopen this PR ? |
SGTM. |
2c4df6b
to
6230f00
Compare
Thanks @laipz8200 . The code and the PR's description have been updated, narrowed to minor fix in logging text and unused variable. May I ask for a second round of review in this , @JohnJyong ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JohnJyong and I reviewed this change together. Thank you for your contribution! |
Cool. I'm always glad to have Dify team's feedback and advices. |
Summary
Cleaned unused dataset
toCleaned messages
inclean_message
periodical taskpage
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods