Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle redis authentication for healthcheck command #10907

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

shisaru292
Copy link
Contributor

Summary

Fixes #10898

This PR includes the following changes:

Brief explanation: The env_file parameter is used to pass environment variables to containers, while variables in the docker compose yaml file like ${REDIS_PASSWORD:-difyai123456} require environment variables during docker-compose command execution. Since the middleware env file in the documentation won't be automatically loaded as a .env file, the --env-file flag is necessary for docker-compose commands to properly substitute default values with the complete environment variables.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Sorry, something went wrong.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working 📚 documentation Improvements or additions to documentation labels Nov 20, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 20, 2024
@crazywoola crazywoola merged commit b42b333 into langgenius:main Nov 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ineffective Redis health check implementation
2 participants