Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted docker manifests and environment variables for OceanBase vector database #10395

Conversation

powerfooI
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This PR makes vector module of oceanbase database turn on automatically after composed up as the main purpose. By the way, it sets database password to default non-empty value and adds some comments for oceanbase vector database.

Fixes #10394

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

I have tested the change and it works as expect.

  1. Edit VECTOR_STORE=oceanbase in .env
  2. Compose up containers with docker compose --profile oceanbase up -d
  3. Store and retrieve vector data as usual without any other manual configuration

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Nov 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
@crazywoola crazywoola merged commit 12a9e29 into langgenius:main Nov 7, 2024
9 checks passed
@powerfooI powerfooI deleted the enhancement/oceanbase-turn-on-vector-auto branch November 7, 2024 05:58
iamjoel pushed a commit that referenced this pull request Nov 7, 2024
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn on vector module of OceanBase vdb automatically deployed through docker-compose
2 participants