Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce multi select for tools input #10201

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Nov 2, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

before after
a9e38b9f1009244848093bbf0cf9309 ee54363b028df4537e3227c1527edc4

changes

  1. Added multi-select input type:

    • Improves user experience by allowing selection from predefined options
    • Eliminates need for manual text input, reducing potential errors
    • Simplifies development by removing need for input validation and string-to-array conversion
  2. Modified output format of Firecrawl crawl/scrape tool, to the new multi-select input type

  3. Removed validate_parameters method from BuiltinToolProviderController. This method was redundant as it duplicated functionality in the base class ToolProviderController

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

test locally

  • multi-select of form in a workflow app
  • multi-select of llm in a workflow app
  • multi-select of form in an agent app
  • multi-select of llm in an agent app

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Nov 2, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 5, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 5, 2024
This reverts commit 024579f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 feat:tools Tools for agent, function call related stuff. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant