fixed score threshold is none

langgenius · Sep 13, 2024 · 43ac320 · 43ac320
1 parent c78828a
commit 43ac320
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/api/core/rag/datasource/retrieval_service.py b/api/core/rag/datasource/retrieval_service.py
@@ -28,7 +28,7 @@ def retrieve(
         dataset_id: str,
         query: str,
         top_k: int,
-        score_threshold: Optional[float] = 0.0,
+        score_threshold: Optional[float] = .0,
         reranking_model: Optional[dict] = None,
         reranking_mode: Optional[str] = "reranking_model",
         weights: Optional[dict] = None,

diff --git a/api/core/rag/retrieval/dataset_retrieval.py b/api/core/rag/retrieval/dataset_retrieval.py
@@ -429,7 +429,7 @@ def _retriever(self, flask_app: Flask, dataset_id: str, query: str, top_k: int,
                         top_k=top_k,
                         score_threshold=retrieval_model.get("score_threshold", 0.0)
                         if retrieval_model["score_threshold_enabled"]
-                        else None,
+                        else 0.0,
                         reranking_model=retrieval_model.get("reranking_model", None)
                         if retrieval_model["reranking_enable"]
                         else None,

diff --git a/api/core/tools/tool/dataset_retriever/dataset_multi_retriever_tool.py b/api/core/tools/tool/dataset_retriever/dataset_multi_retriever_tool.py
@@ -179,7 +179,7 @@ def _retriever(
                         top_k=self.top_k,
                         score_threshold=retrieval_model.get("score_threshold", 0.0)
                         if retrieval_model["score_threshold_enabled"]
-                        else None,
+                        else 0.0,
                         reranking_model=retrieval_model.get("reranking_model", None)
                         if retrieval_model["reranking_enable"]
                         else None,

diff --git a/api/core/tools/tool/dataset_retriever/dataset_retriever_tool.py b/api/core/tools/tool/dataset_retriever/dataset_retriever_tool.py
@@ -72,7 +72,7 @@ def _run(self, query: str) -> str:
                     top_k=self.top_k,
                     score_threshold=retrieval_model.get("score_threshold", 0.0)
                     if retrieval_model["score_threshold_enabled"]
-                    else None,
+                    else 0.0,
                     reranking_model=retrieval_model.get("reranking_model", None)
                     if retrieval_model["reranking_enable"]
                     else None,

diff --git a/api/services/hit_testing_service.py b/api/services/hit_testing_service.py
@@ -42,7 +42,7 @@ def retrieve(cls, dataset: Dataset, query: str, account: Account, retrieval_mode
             top_k=retrieval_model.get("top_k", 2),
             score_threshold=retrieval_model.get("score_threshold", 0.0)
             if retrieval_model["score_threshold_enabled"]
-            else None,
+            else 0.0,
             reranking_model=retrieval_model.get("reranking_model", None)
             if retrieval_model["reranking_enable"]
             else None,