-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imperative API #2378
Draft
nfcampos
wants to merge
15
commits into
main
Choose a base branch
from
nc/8nov/send-future
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Imperative API #2378
+956
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
force-pushed
the
nc/4nov/send-eager
branch
from
November 11, 2024 22:09
f885527
to
3ad966e
Compare
nfcampos
force-pushed
the
nc/8nov/send-future
branch
2 times, most recently
from
November 11, 2024 22:18
6fdbbc6
to
3e0395b
Compare
nfcampos
changed the title
Add
Add Nov 12, 2024
call
function to call a node and get a futurecall
function to call a node and get a future & Imperative API
nfcampos
force-pushed
the
nc/8nov/send-future
branch
from
November 14, 2024 22:59
3e0395b
to
bd255c2
Compare
nfcampos
changed the title
Add
Imperative API
Nov 20, 2024
call
function to call a node and get a future & Imperative API
nfcampos
force-pushed
the
nc/8nov/send-future
branch
from
November 20, 2024 01:04
d1a8b53
to
3d5df68
Compare
nfcampos
commented
Nov 20, 2024
nfcampos
commented
Nov 20, 2024
- Whereas Send is for fire-and-forget type of calls, new `call` and `acall` functions are for flows where you want to wait for the node to finish before doing something else - Because we return regular python future objects (concurrent.futures.Future or asyncio.Future) all the python primitives for working with futures work, eg. wait, gather, etc
nfcampos
force-pushed
the
nc/8nov/send-future
branch
from
November 26, 2024 00:13
2f396ac
to
5fdba64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send
is for fire-and-forget type of calls, newcall
andacall
functions are for flows where you want to wait for the node to finish before doing something else