Add redis storage #8980
Merged
Add redis storage #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:enhancement
baskaryan
approved these changes
Aug 9, 2023
|
|
||
| self.ttl = ttl | ||
| self.namespace = namespace | ||
| self.namespace_delimiter = "/" |
There was a problem hiding this comment.
worth making this configurable? if not, does it need to be stored as attribute (allows folks to mess with it)
| """ | ||
|
|
||
| def __init__( | ||
| self, client: Any, *, ttl: Optional[int] = None, namespace: Optional[str] = None |
There was a problem hiding this comment.
could type hint client if you wanted to
|
Merging and following up with PR to address remaining issues (since they were not blocking) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a redis implementation of a BaseStore