Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partners[chroma]: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI #28345

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lucasile
Copy link

@lucasile lucasile commented Nov 26, 2024

New Integration Tests for Chroma server using Async api

image

Addressing #27225

  • PR title: "package: description"

    • Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"
  • PR message:

    • Description: Allow Chroma Vectorstore to accept AsyncClientAPI alongside ClientAPI and implement asynchronous functions to use it.
    • Dependencies: no new - chromadb
  • Add tests and docs:

  1. Added integration tests for new async functionality

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 5:53am

@lucasile lucasile changed the title **Add Async Functionality to ChromaDB**: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI **Add Async Functionality to ChromaDB**: "partners: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI" Nov 26, 2024
@lucasile lucasile changed the title **Add Async Functionality to ChromaDB**: "partners: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI" **Async ChromaDB**: "partners: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI" Nov 26, 2024
@lucasile lucasile closed this Nov 26, 2024
@lucasile lucasile reopened this Nov 26, 2024
@lucasile lucasile closed this Nov 26, 2024
@lucasile lucasile reopened this Nov 26, 2024
@lucasile lucasile closed this Nov 26, 2024
@lucasile lucasile reopened this Nov 26, 2024
@lucasile lucasile marked this pull request as ready for review November 26, 2024 05:57
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module labels Nov 26, 2024
@lucasile lucasile changed the title **Async ChromaDB**: "partners: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI" partners[chroma]: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

1 participant