Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support token usage in streaming #30

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Support token usage in streaming #30

merged 3 commits into from
Oct 21, 2024

Conversation

B-Step62
Copy link
Collaborator

@B-Step62 B-Step62 commented Oct 21, 2024 •
edited
Loading

Resolve #9

ChatOpenAI support streaming token usage, ChatDatabricks should be compatible with it.

Test

  • Unit test
  • Integration test against FMAPI endpoint.
  • Manual test

Screenshot 2024-10-21 at 14 32 14

@B-Step62 B-Step62 requested a review from harupy October 21, 2024 05:32
harupy
harupy approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comments are addressed.

@B-Step62
comment
d325004 
Signed-off-by: B-Step62 <[email protected]>
@B-Step62 B-Step62 merged commit 43404a1 into langchain-ai:main Oct 21, 2024
8 checks passed
@B-Step62 B-Step62 deleted the stream-tokens branch October 21, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harupy harupy harupy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not getting token usage metadata with ChatDatabricks streaming
2 participants
@B-Step62 @harupy