Make 'endpoint' parameter optional for DatabricksVectorSearch #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: B-Step62 <[email protected]>
harupy
reviewed
Sep 20, 2024
harupy
reviewed
Sep 20, 2024
Signed-off-by: B-Step62 <[email protected]>
harupy
reviewed
Sep 20, 2024
| endpoint_name=endpoint, index_name=index_name | ||
| ) | ||
| except Exception as e: | ||
| if endpoint is None and "Wrong vector search endpoint" in str(e): |
There was a problem hiding this comment.
where does Wrong vector search endpoint come from?
There was a problem hiding this comment.
It is the exception raised from the VectorSearch client (< 0.35). It is not open-sourced or documented either unfortunately😔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #16.
The vector search client no longer requires
endpoint_nameparameter, so we can make it optional in the constructor as well.