Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kevin Williams PA1 #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kevin504
Copy link

No description provided.

# Author: Kevin Williams
# Assignment: PA[X]
# Date: Date of submission

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't put everything together into 1 file. I have to run these to evaluate them. Normally, if it doesn't compile I'll mark it 0 and move on, but I'll separate the code for you this time.

@JShrein
Copy link

JShrein commented Feb 19, 2015

SCORE: 82

Please don't put everything together into 1 file. I have to run these to evaluate them. Normally, if it doesn't compile I'll mark it 0 and move on, but I'll separate the code for you this time.

PART 1:
Total: -5

-5 Accepts input greater than 9. This allows storing numbers beyond the bounds of the array.

PART 2:
Total: -0

Very Nice!
Great style and organization
Followed all directions

PART 3:
Total: -13

-5 Line 14: why testing against 11 instead of 15?
-6 Instructions require to store and retrieve partial sum value from memory each iteration.
-2 Line 23: You have not called a function, so no need to return to $ra ($ra is 0 here so this results in a crash)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants