Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA1_KendalHarris #23

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

kcoleharris
Copy link

No description provided.

kcoleharris and others added 9 commits February 11, 2015 12:30

jr $ra # return from subroutine
# End of subroutine to print the numbers on one line
###############################################################
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Program runs correctly and produced correct results.

@JShrein
Copy link

JShrein commented Feb 19, 2015

SCORE: 88

Excellent commenting in all three parts, please keep that up.

PART 1:
Total: -0

Program runs correctly and produced correct results.

PART 2:
Total: -10

-2 Lines 61 and 62:
It is not necessary to use 'la $ax, ($sx)'. MIPS is perfectly happy to multiply numbers from registers in the $sx range. More importantly, this is not a good way to move the numbers to those registers. 'la' is meant to load an address into a register. Your $s1 and $s2 do not hold meaningful addresses, they hold literal values. When you use ($s1) you're saying get me that address of $s1, which happens to be the literal, and load it into $a0. 'move' or 'add' would be more proper.

-8 The instructions require that your intermediate results are stored into memory, and are later retrieved for printing. You've declared an array "values", presumably for this purpose, and you've loaded the address of "values" into $s0, but you never use $s0 after that.

Other portions of the program function correctly.

PART 3:
Total: -2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants