Ensure float literals and float versions of math functions are used. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-carlos
force-pushed
the
float-math-funcs
branch
2 times, most recently
from
92a4e61 to
17016e2
Compare
microbit-carlos
changed the title
Compass & LevelDetectorSPL are using float versions of math functions.
microbit-carlos
force-pushed
the
float-math-funcs
branch
from
17016e2 to
6fde02e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically for
LevelDetectorSPL::pullRequest(), as float in the micro:bit's Cortex-M4f is much faster and this function runs a lot in the background.Related PR:
SoundSynthesizerEffects&CompassCalibrator. codal-microbit-v2#454