Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove using namespace directive in a header #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nedseb
Copy link
Contributor

@nedseb nedseb commented Mar 31, 2021

A using namespace inside a header makes useless namespace so it should be removed.

A `using namespace` inside a header makes useless namespace so it should be removed.
@finneyj
Copy link
Contributor

finneyj commented Mar 31, 2021

Thanks @nedseb.

I agree that this using directive shouldn't be here. I seem to recall that it was a "quick fix" necessary to support transparency for microbit-v2 (out biggest user). I think there are also other directives like this in other .h files that we should remove at the same time. Doing so will require us to ensure that we don't introduce incompatibilities though...

@nedseb
Copy link
Contributor Author

nedseb commented Mar 31, 2021

Yes, I understand....
In the beginning, I made this PR because I want to see if this change will break the CI to know if this line was here for a good reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants