Removing "OPTIONAL" keyword #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcr
approved these changes
Dec 18, 2023
|
@hannestschofenig I don't agree with this change. I thought there were some attestation statement formats where either the certs are buried inside the proprietary statement format, or where the certs can be omitted because they are already known to the verifier. Are you sure that the certs can be mandatory? |
|
Meeting with Hannes and Henk. Decision: put the OPTIONAL back and instead make the sequences SIZE (1..MAX). This follow X.509 conventions in RFC5280, for example: |
|
Because we made another change to the same lines (now on main), I could not easily continue this PR. I have started a new one, see #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.