General QA #58
Merged
General QA #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, delete markdown lint config so that the default config is used in CI Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Merged
samsonasik
reviewed
Oct 30, 2024
Signed-off-by: George Steel <[email protected]>
samsonasik
approved these changes
Oct 30, 2024
| @@ -59,7 +59,7 @@ To register a listener in a laminas-mvc based application, use either applicatio | |||
|
|
|||
| This example uses module configuration, e.g. `module/Application/config/module.config.php`: | |||
|
|
|||
| <pre class="language-php" data-line="4-6"><code> | |||
| ```php | |||
There was a problem hiding this comment.
@gsteel
You have removed the line highlighting: https://docs.laminas.dev/laminas-eventmanager/application-integration/usage-in-a-laminas-mvc-application/#register-listener
gsteel
added a commit
to gsteel/laminas-eventmanager
that referenced
this pull request
Oct 31, 2024
Signed-off-by: George Steel <[email protected]>
gsteel
added a commit
that referenced
this pull request
Oct 31, 2024
Reinstate line-highlights removed in #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gets CI Green Again…