Add hint to documentation #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meidlinga
force-pushed
the
patch-1
branch
2 times, most recently
from
1312ebd to
c406a52
Compare
Add a hint about getAdatpter when using MasterSlaveFeature to the documentation. Signed-off-by: meidlinga <[email protected]>
settermjd
reviewed
Jun 15, 2022
| @@ -181,7 +181,8 @@ There are a number of features built-in and shipped with laminas-db: | |||
|
|
|||
| - `MasterSlaveFeature`: the ability to use a master adapter for `insert()`, | |||
| `update()`, and `delete()`, but switch to a slave adapter for all `select()` | |||
| operations. | |||
| operations. Calling `getAdapter()` on `TableGateway` will still return the | |||
| master adapter. | |||
There was a problem hiding this comment.
You can have multiple database adapters configured in your application. So, for me, this statement could be misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a hint about getAdatpter when using MasterSlaveFeature to the documentation.
Description
I was using a custom SQL statement with TableGateway and had to consult the source code to ensure on which adapter it will be executed. I think adding this information to the documentation will save others some time in the future.