-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin issue#214 #220
Closed
Closed
Origin issue#214 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameters"/change failure test to any exception (because github-ci messages different of local messages)
…rameters"/change code style by phpcs and "laminas/laminas-coding-standard"
…rameters"/delete commited "phpcs.xml" (i'm sorry)
Whats wrong? //test/unit/Sql/AbstractSqlTest.php
public function testProcessExpressionWorksWithNamedParameterPrefix()
{
$parameterContainer = new ParameterContainer();
$namedParameterPrefix = uniqid();
$expression = new Expression('FROM_UNIXTIME(?)', [10000000]);
$this->invokeProcessExpressionMethod($expression, $parameterContainer, $namedParameterPrefix);
// $namedParameterPrefix is '6151d11d5aeaf';
// $namedParameterPrefix . '1' is '6151d11d5aeaf1';
// key($parameterContainer->getNamedArray()) is '6151d11d5aeaf1'
self::assertSame($namedParameterPrefix . '1', key($parameterContainer->getNamedArray())); // LINE 154: debug data above
}
|
…rameters"/fix test "testBindParamByFieldNameIsFail" - wrong name of a fieldName
…tNamedParameters"/fix test "testBindParamByFieldNameIsFail" - wrong name of a fieldName" This reverts commit 808c64a
…rameters"/fix test "testBindParamByFieldNameIsFail" - wrong name of a fieldName
…rameters"/All in root of the project is ignore Signed-off-by: ZVanoZ <[email protected]>
I will try new pull request with one signed commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixed issue #214
@node: I'm trying to pass githab CI.