Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin issue#214 #220

Closed
wants to merge 8 commits into from
Closed

Origin issue#214 #220

wants to merge 8 commits into from

Conversation

ZVanoZ
Copy link
Contributor

@ZVanoZ ZVanoZ commented Sep 24, 2021

This pull request fixed issue #214
@node: I'm trying to pass githab CI.

…rameters"/change failure test to any exception (because github-ci messages different of local messages)
…rameters"/change code style by phpcs and "laminas/laminas-coding-standard"
…rameters"/delete commited "phpcs.xml" (i'm sorry)
@ZVanoZ
Copy link
Contributor Author

ZVanoZ commented Sep 27, 2021

Whats wrong?
Forum
Pull request to fix the error is here - #223

//test/unit/Sql/AbstractSqlTest.php
    public function testProcessExpressionWorksWithNamedParameterPrefix()
    {
        $parameterContainer   = new ParameterContainer();
        $namedParameterPrefix = uniqid();
        $expression           = new Expression('FROM_UNIXTIME(?)', [10000000]);
        $this->invokeProcessExpressionMethod($expression, $parameterContainer, $namedParameterPrefix);
// $namedParameterPrefix                     is '6151d11d5aeaf'; 
// $namedParameterPrefix . '1'               is '6151d11d5aeaf1'; 
// key($parameterContainer->getNamedArray()) is '6151d11d5aeaf1'
        self::assertSame($namedParameterPrefix . '1', key($parameterContainer->getNamedArray())); // LINE 154: debug data above
    }
2021-09-26T13:19:58.1541476Z --
2021-09-26T13:19:58.1541721Z 
2021-09-26T13:19:58.1542106Z There was 1 failure:
2021-09-26T13:19:58.1542418Z 
2021-09-26T13:19:58.1543774Z 1) LaminasTest\Db\Sql\AbstractSqlTest::testProcessExpressionWorksWithNamedParameterPrefix
2021-09-26T13:19:58.1546087Z Failed asserting that 61507378202901 is identical to '61507378202901'.
2021-09-26T13:19:58.1546525Z 
2021-09-26T13:19:58.1558191Z ##[error]/github/workspace/test/unit/Sql/AbstractSqlTest.php:154
2021-09-26T13:19:58.1570288Z 
2021-09-26T13:19:58.1571489Z --

…rameters"/fix test "testBindParamByFieldNameIsFail" - wrong name of a fieldName
…tNamedParameters"/fix test "testBindParamByFieldNameIsFail" - wrong name of a fieldName"

This reverts commit 808c64a
…rameters"/fix test "testBindParamByFieldNameIsFail" - wrong name of a fieldName
…rameters"/All in root of the project is ignore

Signed-off-by: ZVanoZ <[email protected]>
@ZVanoZ ZVanoZ closed this Sep 28, 2021
@ZVanoZ
Copy link
Contributor Author

ZVanoZ commented Sep 28, 2021

I will try new pull request with one signed commit.

@ZVanoZ ZVanoZ deleted the origin-issue#214 branch September 28, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant