-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds PHP 8.3 as new supported version #74
Conversation
Signed-off-by: Stéphane Demonchaux <[email protected]>
Signed-off-by: Stéphane Demonchaux <[email protected]>
Thanks, @fezfez. Will see when I find some time to remove all changes besides So once I find some time, I will:
If you find some time meanwhile, feel free to revert those changes so that we can merge this. |
i have clean some psalm error, if you agree i prefer moving forward instead of backward, i have left two error that i think can be easily cleaned with some knowledge that i don't have |
Its absolutely fine that you prefer going forward. Therefore, I will definitely remove these changes. Most of the psalm stuff cannot be changed anyways as almost any return types/property types are invalid starting in Since there will be a new major version for We do have a bunch of stuff baselined regarding laminas, thats most likely since there was never a check if the types are always like they're stated (besides the fact that some1 added unit tests which only test happy-path). Therefore, we sadly have to live with the fact that psalm will report a bunch of stuff until we are able to fix these in new versions (sometimes even in majors as "making psalm happy" and "breaking stuff" is sometimes unavoidable). |
@boesing see https://github.com/laminas/laminas-cache-storage-adapter-filesystem/pull/75/files i dont understand the main reason to not run baseline, i have done it in a lot of pull request edit : see https://github.com/laminas/laminas-cache/pull/280/files as example |
Superseded by #75 |
No description provided.