Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests using the new env var #85

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

jordibonet-lambdaclass
Copy link

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@jordibonet-lambdaclass jordibonet-lambdaclass changed the title Fix tests using the new env var fix: tests using the new env var Jan 31, 2024
@jordibonet-lambdaclass jordibonet-lambdaclass marked this pull request as draft January 31, 2024 12:56
@jordibonet-lambdaclass jordibonet-lambdaclass marked this pull request as ready for review February 1, 2024 11:47
Copy link

@toni-calvin toni-calvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

let isValidium: Boolean = false;
try {
const fileContent = await fs.promises.readFile(filePath, 'utf-8');
const keyValuePairs = fileContent.split('\n').map((line) => line.trim().split('='));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a more optimal way to do this

@toni-calvin toni-calvin merged commit ea1c727 into fix-integration-test Feb 1, 2024
6 of 9 checks passed
@toni-calvin toni-calvin deleted the validium-fix-test-new-env-value branch February 1, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants