Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: system test for rollup #84

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: system test for rollup #84

merged 3 commits into from
Jan 31, 2024

Conversation

jordibonet-lambdaclass
Copy link

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

toni-calvin
toni-calvin reviewed Jan 31, 2024
View reviewed changes
Copy link

@toni-calvin toni-calvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I left some reviews that maybe are better for performance

core/tests/ts-integration/tests/system.test.ts Outdated Show resolved Hide resolved
core/tests/ts-integration/tests/system.test.ts Outdated Show resolved Hide resolved
toni-calvin
toni-calvin approved these changes Jan 31, 2024
View reviewed changes
Copy link

@toni-calvin toni-calvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jordibonet-lambdaclass jordibonet-lambdaclass merged commit 9cc0375 into fix-integration-test Jan 31, 2024
6 of 9 checks passed
@jordibonet-lambdaclass jordibonet-lambdaclass deleted the validium-fix-test-for-rollup branch January 31, 2024 11:22
@jordibonet-lambdaclass jordibonet-lambdaclass restored the validium-fix-test-for-rollup branch January 31, 2024 11:22
@jordibonet-lambdaclass jordibonet-lambdaclass deleted the validium-fix-test-for-rollup branch January 31, 2024 11:22
Oppen pushed a commit that referenced this pull request Feb 9, 2024
@StanislavBreadless
Rollback oz version change (#84)
df589d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toni-calvin toni-calvin toni-calvin approved these changes

Assignees

@jordibonet-lambdaclass jordibonet-lambdaclass

Labels
external-contribution validium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordibonet-lambdaclass @toni-calvin @jorbush