feat: Fix integration test #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Needs to fix errors in tests related to the new Generic Data Type
* Fix system tests * Fix contracts tests for validium mode * Update comment * Fix custom-erc20-bridge test * Revert "Fix custom-erc20-bridge test" This reverts commit f2e9978. * Fix web3 test * Add check validium mode in system test * Format
…ods from L1BatchWithMetadata as they're now part of the L1BatchCommitter trait and utils in the case of construct_pubdata
…mmitOperation construction and DatasizeCriterion::last_l1_batch_to_publish usage
…_publish parameter (only used by DataSizeCriterion)
…tter::l1_commit_data function
…l1_commit_data function
…ter depending on the VALIDIUM_MODE env value
…class/zksync-era into feat_validium_pubdata_abstraction
* Fix System test for rollup mode * Update core/tests/ts-integration/tests/system.test.ts senderNonce Co-authored-by: Antonio Calvín García <[email protected]> * Update core/tests/ts-integration/tests/system.test.ts nonce Co-authored-by: Antonio Calvín García <[email protected]> --------- Co-authored-by: Antonio Calvín García <[email protected]>
…class/zksync-era into fix-integration-test
…era into fix-integration-test
* Fix eth_sender value * Restore original config file and omit commented values * Format
ilitteri
requested changes
Feb 5, 2024
toni-calvin
force-pushed
the
fix-integration-test
branch
from
f740993
to
e1312ff
Compare
* Remove web3 error * Optimize updateConfigFile * Format * update compute_overhead constants in chain.toml --------- Co-authored-by: toni-calvin <[email protected]>
|
We have changed the COMPUTE_OVERHEAD to be changeable because it was not passing the tests in Rollup, it was one of the first fixes we made (it fixes a bug in the web3 suite, from the gas difference). We have also optimized the "updateConfigFile()" function to be of complexity O(n+m) instead of O(m·n), where "m" is the number of parameters and "n" is the number of lines in the configuration file. |
…class/zksync-era into fix-integration-test
…class/zksync-era into feat_validium_pubdata_abstraction
…class/zksync-era into fix-integration-test
* Update new variables between modes * Format
This reverts commit 051f173.
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
* System contracts test preprocessing mode * Mock dependencies, event writer asm contract test, refactoring * lint fix * Small refactoring * Change approach to use the test node * Add docs, comments * lint readme * Fix hashes * Regenerate yarn.lock to fix lints * lint:fix * Fix lints * Restore lost tests * Fix lints * Restore yarn.lock from dev * Update caches in workflows * Try to disable lint cache * Restore lint cache * Cache contracts-preprocessed * try to debug lint * Regenerate yarn.lock from dev * Restore correct deps * Update lock * Proposed improvements/fixes * Use fast-glob instead glob * Update bootloader_test artifact path * Proposed improvements, update hashes * Implement some fixes and improvements * Fix lints * Update zksync-era in bootloader tests * Fix imports Signed-off-by: Danil <[email protected]> * Update contracts/test-contracts/MockContract.sol Co-authored-by: Vlad Bochok <[email protected]> * Fix test infra * data -> input mock contract * Update SC hashes * Update zksync-era in bootloader/test_infra * Update again --------- Signed-off-by: Danil <[email protected]> Co-authored-by: Danil <[email protected]> Co-authored-by: Vlad Bochok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In roll-up mode:
In validium mode: