Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add zks_getBatchPubdata endpoint #79

Open
wants to merge 11 commits into
base: feat_validium_pubdata_abstraction
Choose a base branch
from
Open

feat: Add zks_getBatchPubdata endpoint #79

wants to merge 11 commits into from

Conversation

ilitteri
Copy link
Collaborator

@ilitteri ilitteri commented Jan 29, 2024 •
edited
Loading

Resolves #72

Description

This PR adds an endpoint to the RPC that'll let a user like Validium's DA Manager get some batch's pubdata to store in some DA Layer.

How to test

  1. Run the hole stack (zk && zk clean --all && zk init)
  2. Run the following curl
curl http://localhost:3050  -X POST \
  -H "Content-Type: application/json" \
  --data '{"method":"zks_getBatchPubdata","params":[1],"id":1,"jsonrpc":"2.0"}'

@ilitteri ilitteri requested a review from jrchatruc January 29, 2024 22:40
@ilitteri ilitteri self-assigned this Jan 29, 2024
@ilitteri ilitteri linked an issue Jan 29, 2024 that may be closed by this pull request
Abstraction: New RPC endpoing for queryng pubdata #72
Closed
@ilitteri ilitteri changed the title feat: Add zks_getL1BatchPubdata endpoint feat: Add zks_getBatchPubdata endpoint Jan 30, 2024
@ilitteri ilitteri changed the base branch from validium_mode_new_fee_model_final to feat_validium_pubdata_abstraction January 30, 2024 19:19
jordibonet-lambdaclass
jordibonet-lambdaclass approved these changes Jan 31, 2024
View reviewed changes
Copy link

@jordibonet-lambdaclass jordibonet-lambdaclass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilitteri
Merge branch 'feat_validium_pubdata_abstraction' of github.com:lambda…
adcfd97 
…class/zksync-era into feat_get_batch_pubdata_endpoint
@ilitteri
Merge branch 'feat_validium_pubdata_abstraction' of github.com:lambda…
970693e 
…class/zksync-era into feat_get_batch_pubdata_endpoint
@ilitteri
Merge branch 'feat_validium_pubdata_abstraction' of github.com:lambda…
ac77506 
…class/zksync-era into feat_get_batch_pubdata_endpoint
Oppen pushed a commit that referenced this pull request Feb 9, 2024
@StanislavBreadless
Update hardhat version (#79)
86f2436
@ilitteri
Merge branch 'feat_validium_pubdata_abstraction' of github.com:lambda…
575076c 
…class/zksync-era into feat_get_batch_pubdata_endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordibonet-lambdaclass jordibonet-lambdaclass jordibonet-lambdaclass approved these changes

@toni-calvin toni-calvin toni-calvin approved these changes

@jrchatruc jrchatruc Awaiting requested review from jrchatruc

Assignees

@ilitteri ilitteri

Labels
external-contribution validium
Projects
None yet
Milestone
Validium Mode: Make it beautiful
Development

Successfully merging this pull request may close these issues.

Abstraction: New RPC endpoing for queryng pubdata
3 participants
@ilitteri @toni-calvin @jordibonet-lambdaclass