Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix zk init in rollup mode #77

Merged
merged 1 commit into from
Jan 29, 2024
Merged

feat: fix zk init in rollup mode #77

merged 1 commit into from
Jan 29, 2024

Conversation

toni-calvin
Copy link

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

ilitteri
ilitteri requested changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, well done! We can merge after reverting the yarn.lock changes.

yarn.lock Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert these changes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@ilitteri ilitteri added this to the Validium Mode: Make it work milestone Jan 29, 2024
ilitteri
ilitteri approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilitteri ilitteri merged commit bf32093 into validium_mode_new_fee_model_final Jan 29, 2024
6 of 8 checks passed
@ilitteri ilitteri deleted the fix-zk-init branch January 29, 2024 16:56
Oppen pushed a commit that referenced this pull request Feb 9, 2024
@vladbochok @StanislavBreadless
Remove allow list (#77)
52aa57f 
Co-authored-by: Stanislav Breadless <[email protected]>
Oppen pushed a commit that referenced this pull request Feb 9, 2024
@StanislavBreadless
Merge pull request #77 from matter-labs/main
dbb37fc 
Sync dev with main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

Assignees

@toni-calvin toni-calvin

Labels
external-contribution validium
Projects
None yet
Milestone
Validium Mode: Make it work
Development

Successfully merging this pull request may close these issues.
2 participants
@toni-calvin @ilitteri