-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: How to reproduce - Validium Readme #44
feat: How to reproduce - Validium Readme #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some somments, but lgtm!
If anyone wants to see how it looks like with the block quotes: https://github.com/lambdaclass/zksync-era/tree/validium-example-readme/validium_mode_example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks great! We just need to remove the old validium.md
Ok! I had thought about putting some information about Validium in that file, but the official ZKSync page is down so you're right I'd better remove the file. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* set pubdata constants to 0 * Set to 0 * Create contract for writing bytes * Deploy bytes contract * update full node to use rpc providers * fmt * add colored prints * add better debug logs * add better logs * add erc20 contract and update test * update logs * print gas used * Use `ETH_SENDER_SENDER_VALIDIUM_MODE` to check whether we need to charge the pubdata * wip * wip 2: just change runtime behavior * Restore original values * Add validium example readme (#34) * Add validium example readme * update validium.md and change test name * fmt --------- Co-authored-by: toni-calvin <[email protected]> * Only keep changes for vm_latest * Fix submodule * Fix integration test license * change contracts branch * Remove l1 gas data * Update submodule branch * fix: update output readme (#39) * Update output readme * Add a note for transactions * Fix note * feat: remove logs pubdata (#42) * remove logs from pubdata * update comment * feat: refactor readme example (#44) * Refactor readme example * Fix some comments * Remove validium.md * Remove debug prints * Remove debug files * zk fmt --------- Co-authored-by: toni-calvin <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: Jordi <[email protected]> Co-authored-by: Jordi <[email protected]> Co-authored-by: Matías Onorato <[email protected]> Co-authored-by: Antonio Calvín García <[email protected]>
What ❔
Why ❔
Checklist
zk fmt
andzk lint
.zk spellcheck
.