Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eigen-client-extra-features): minimal client changes #362

Conversation

juan518munoz
Copy link

What ❔

Minimal changes to make client migration an easier process.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

let client = Arc::new(Mutex::new(
DisperserClient::connect(endpoint)
.await
.map_err(|e| anyhow::anyhow!("Failed to connect to Disperser server: {}", e))?,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why anyhow here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually unneeded, I have removed it!

@gianbelinche gianbelinche merged commit 163c41a into eigen-client-extra-features Nov 28, 2024
4 of 7 checks passed
@gianbelinche gianbelinche deleted the eigen-client-extra-features-client-preparation branch November 28, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants