Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eigen-client-extra-features): Small changes #358

Merged
merged 7 commits into from
Nov 28, 2024
Merged

feat(eigen-client-extra-features): Small changes #358

merged 7 commits into from
Nov 28, 2024

Conversation

gianbelinche
Copy link

What ❔

This PR makes some small changes including:

  • Rename eth_confirmation_depth to settlement_layer_confirmation_depth
  • Removing blob_size_limit from config
  • Move reserved to bottom of proto
  • Rename loop_verify_certificate
  • Move constants to lib

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@gianbelinche gianbelinche merged commit 99c6d42 into eigen-client-extra-features Nov 28, 2024
4 of 7 checks passed
@gianbelinche gianbelinche deleted the eigen-client-small-changes branch November 28, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan518munoz juan518munoz juan518munoz approved these changes

@juanbono juanbono juanbono approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gianbelinche @juanbono @juan518munoz