Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eigen-client-extra-features): Backon #344

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

gianbelinche
Copy link

What ❔

This PR adds backon retrys instead of loops with sleeps

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

(|| async { self.verifier.verify_certificate(blob_info.clone()).await })
.retry(
&ConstantBuilder::default()
.with_delay(Duration::from_secs(12))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use a constant here

Copy link

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use constant

@gianbelinche gianbelinche merged commit 09ecfdd into eigen-client-extra-features Nov 19, 2024
4 of 7 checks passed
@gianbelinche gianbelinche deleted the eigen-client-backon branch November 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants