Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eigen-client-extra-features): fix clippy and add doc #330

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat(eigen-client-extra-features): fix clippy and add doc #330

merged 2 commits into from
Nov 8, 2024

Conversation

juan518munoz
Copy link

What ❔

  • Fix all cargo check and cargo clippy warnings.
  • Add documentation to public structures.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

juanbono
juanbono requested changes Nov 8, 2024
View reviewed changes
Copy link

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are public structs without docs

juanbono
juanbono approved these changes Nov 8, 2024
View reviewed changes
Copy link

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized that the pending structs without docs are not public ones.

@juanbono juanbono merged commit 94ecb52 into eigen-client-extra-features Nov 8, 2024
14 of 25 checks passed
@juanbono juanbono deleted the eigen-client-clippy-and-doc branch November 8, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juan518munoz @juanbono