Update kimchi branch #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablodeymo
pushed a commit
that referenced
this pull request
Oct 11, 2023
* WIP continuing fiat-shamir (step 20) * Upto step 20 implemented * Upto step 22 * Upto step 28 * Added tests * Fix build errors * Small fix * Finished fiatshamir, except from some details * Build fixes * Fix errors * Partially implemented PolishToken * Implemented cell variant in evaluate * Fix srs * Format verifier_circuit_tests * Ignore inv test * Fixed scalar and polycomm tests * Added extended euclidean for scalar inverse * WIP updating VerifierIndex deser * WIP * WIP VerifierIndex serde * Finished VerifierIndex serde * Added ft_eval1 field to proof serde * Fix absorbScalars() * Fixed powers of alpha * Fix alphas * Finished fiat-shamir * Fmt and tidy up rust crate * Fix clippy * Added 4th step * Update kimchi branch (#31) * Update kimchi branch * Fix clippy
pablodeymo
pushed a commit
that referenced
this pull request
Oct 11, 2023
* WIP continuing fiat-shamir (step 20) * Upto step 20 implemented * Upto step 22 * Upto step 28 * Added tests * Fix build errors * Small fix * Finished fiatshamir, except from some details * Build fixes * Fix errors * Partially implemented PolishToken * Implemented cell variant in evaluate * Fix srs * Format verifier_circuit_tests * Ignore inv test * Fixed scalar and polycomm tests * Added extended euclidean for scalar inverse * WIP updating VerifierIndex deser * WIP * WIP VerifierIndex serde * Finished VerifierIndex serde * Added ft_eval1 field to proof serde * Fix absorbScalars() * Fixed powers of alpha * Fix alphas * Finished fiat-shamir * Fmt and tidy up rust crate * Fix clippy * Added 4th step * Update kimchi branch * Fix clippy * Added step 5 * Added serialization of newly added data * Added step 6 * Revert "Added step 6" This reverts commit 98a596d. * Update kimchi branch (#31) * Update kimchi branch * Fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verifier circuit tests were using kimchi's
masterbranch while the circuit itself was being based on thedevelopbranch, but particularly in an old commit of the branch. This PR updates the kimchi dependency to the last commit and fixes every difference needed to verify a proof over a test circuit, defined by kimchi.